Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v0.4.1 #101

Merged
merged 3 commits into from
Feb 9, 2023
Merged

release v0.4.1 #101

merged 3 commits into from
Feb 9, 2023

Conversation

MarcoPolo
Copy link
Contributor

No description provided.

@marten-seemann
Copy link
Contributor

Now that’s annoying. Would gorelease still insist on a new minor version if we exclude the Go version bump?

@MarcoPolo
Copy link
Contributor Author

What's the benefit of keeping it a patch release in this case?

@marten-seemann
Copy link
Contributor

If it’s a minor release, the go-libp2p release will have to be another minor as well, according to semver.

@MarcoPolo
Copy link
Contributor Author

Can I simply merge it as a patch or is there something else I should do?

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Suggested version: v0.4.1

Comparing to: v0.4.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index ae42922..868c702 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/multiformats/go-multistream
 
-go 1.18
+go 1.19
 
 require github.com/multiformats/go-varint v0.0.6

gorelease says:

# github.com/multiformats/go-multistream
## incompatible changes
ErrNotSupported: changed from ErrNotSupported[T StringLike] to ErrNotSupported[T StringLike]
Handler: changed from Handler[T StringLike] to Handler[T StringLike]
HandlerFunc: changed from HandlerFunc[T StringLike] to HandlerFunc[T StringLike]
MultistreamMuxer: changed from MultistreamMuxer[T StringLike] to MultistreamMuxer[T StringLike]
NewMultistreamMuxer: changed from func() *MultistreamMuxer[T] to func() *MultistreamMuxer[T]

# summary
Suggested version: v0.5.0

gocompat says:

Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@MarcoPolo
Copy link
Contributor Author

Currently thinking this is a gorelease bug because this output looks identical:

# github.com/multiformats/go-multistream
## incompatible changes
ErrNotSupported: changed from ErrNotSupported[T StringLike] to ErrNotSupported[T StringLike]
Handler: changed from Handler[T StringLike] to Handler[T StringLike]
HandlerFunc: changed from HandlerFunc[T StringLike] to HandlerFunc[T StringLike]
MultistreamMuxer: changed from MultistreamMuxer[T StringLike] to MultistreamMuxer[T StringLike]
NewMultistreamMuxer: changed from func() *MultistreamMuxer[T] to func() *MultistreamMuxer[T]

# summary
Suggested version: v0.5.0

Also if you run gorelease from v0.4.0 branch, you'll still get the suggested version v0.5.0

@MarcoPolo MarcoPolo merged commit 5b2f48e into master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoPolo @marten-seemann